Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landing page redesign #732

Merged
merged 24 commits into from
Oct 16, 2023
Merged

Conversation

chillkang
Copy link
Contributor

@chillkang chillkang commented Oct 3, 2023

Done

  • Updated content and design for the landing page

QA

Notes

  • Images for What is JAAS? section and side navigation tabs will be updated.

Issue / Card

@webteam-app
Copy link
Collaborator

Demo starting at https://jaas-ai-732.demos.haus

Copy link
Contributor

@steverydz steverydz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@AnnSoMuller
Copy link

Hi Seulkee!
Thanks!
I have few comments :)

  1. on the "Add visibility, auditing and compliance controls to your Juju deployment"
  • the screens should be different on the different steps (you can find them in the copy doc
  • here
Screenshot 2023-10-05 at 10 55 41 You can put the description below the title on le left so that there is no 50-50 split (and the title is not on 2 or 3 lines) 2. The logos in the "Deploy and manage charms across public clouds, Kubernetes and VMs" should be aligned with the text on the right (50/50 split) Screenshot 2023-10-05 at 12 03 53

@AnnSoMuller
Copy link

hello,

here may latest comments :)
Screenshot 2023-10-05 at 16 45 41
for better screenshots, maybe we can ask @vladimir-cucu
Thanks!

@Lukewh
Copy link
Contributor

Lukewh commented Oct 6, 2023

3 questions regarding the screenshots:

  1. Why are they all so blurry? 👓
  2. Why is the first one a SVG?
  3. The search and filter one looks broken, would be good to have it on some kind of background so it's the same size as the others?

On issue:
If you click on one of the "tabs" in the "Add visibility, auditing and compliance controls to your Juju deployment" section, the "Previous" and "Next" buttons don't update

@AnnSoMuller
Copy link

Thanks @chillkang
Last thing:
put the text below the title, sorry if it wasn't clear. I have made a screenshot
Screenshot 2023-10-10 at 08 46 01
Thanks!

Copy link
Contributor Author

@chillkang chillkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnnSoMuller changes are updated :)

@AnnSoMuller
Copy link

@chillkang
Thanks for all changes
All good for me! :)

@massigori
Copy link

Some comments form me and Gloria:

  1. The way the lines interrupt the text in the What is Jaas? section is weird. Visually, it's harder to see this is a list of related things because of that
  2. The BT logo in the logo wall might appear in weird positions for certain horizontal window sizing
  3. As mentioned in the in the jaas.ai webpages the logos in the Deploy and manage charms across public clouds, Kubernetes and VMs section are supposed to be arranged in a way that can signal at a glance that we deploy on bare metal, VMs and k8s. The current organisation with the Ubuntu logo and the top and then the rest makes relatively little sense to me
  4. The header is missing the blog link to be consistent with the one on juju.is

Copy link
Contributor Author

@chillkang chillkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@massigori Thanks for the reviews. I'll add the blog link now.

@AnnSoMuller and @lyubomir-popov, what do you think about 1, 2 and 3?

@lyubomir-popov
Copy link

  1. I agree, this layout is better suited to larger sections with a title and a long paragraph. Here, best to just stack them one after the other in a 50/50 layout
  2. This is an inline list - the position depends on the available width, on smaller screens the list of logos wraps. Not sure what is expected?
  3. Please provide more information on the grouping that would signal what is described above. Logos cna be grouped in 3 sections potentially.

@AnnSoMuller
Copy link

  1. I agree with Lyubo
  2. Not sure what "weird" position means neither for the BT logo, a screenshot might help
  3. in the Deploy and manage charms across public clouds, Kubernetes and VMs section, Should all logos then be on the right side?

Copy link
Contributor Author

@chillkang chillkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lyubomir-popov @AnnSoMuller Out of these two, which one better suits for 50-50 layout?
1.
image 1
2.
image 2

@lyubomir-popov
Copy link

@chillkang the first one - to be more specific, I was proposing something like thisd - with muted hrs (hr.p-rule.is-muted):
image

You can see how I've done it here (code here at the bottom )

@chillkang chillkang merged commit 58f72e1 into canonical:main Oct 16, 2023
10 checks passed
@chillkang chillkang deleted the landing-page-redesign branch October 16, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants